test: add test for experimental ESM modules #74
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test demonstrating using c8 for collecting coverage for experimental modules (see conversation here).
I've been meaning to add this test for a while, but haven't had many OSS cycles... it's cool to see it work after months of noodling on V8/Node.js.
Background
The new module system in Node.js does not support
require.extensions
; while there is some work in motion to support similar extension mechanisms, it's unlikely to exist in time for--experimental-modules
to be un-flagged.c8
collects coverage using the inspector and the NODE_V8_COVERAGE environment variable, this is built into Node.js itself and does not require extending loaders.Checklist
npm test
, tests passingnpm run test:snap
(to update the snapshot)CC: @MylesBorins, @joyeecheung, @guybedford, @GeoffreyBooth, @coreyfarrell (CC: party 🎉 woo).