Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Objects.cs #53

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Update Objects.cs #53

merged 1 commit into from
Feb 28, 2019

Conversation

bheesbeen
Copy link
Contributor

Also the CreatedAt and UpdatedAt properties form Buy nullable

Also the CreatedAt and UpdatedAt properties form Buy nullable
@bchavez
Copy link
Owner

bchavez commented Feb 28, 2019

Hi @bheesbeen,

Thank you for the PR. Do you have the JSON response where these fields are nullable? (or maybe a stack trace showing the issue?) I'd like to write some unit tests for these issues.

Thanks,
Brian

@bheesbeen
Copy link
Contributor Author

bheesbeen commented Feb 28, 2019 via email

@bchavez bchavez merged commit cf9aa0e into bchavez:master Feb 28, 2019
bchavez added a commit that referenced this pull request Feb 28, 2019
@bchavez
Copy link
Owner

bchavez commented Feb 28, 2019

Hi Bert,

I've marked all .CreatedAt and .UpdatedAt fields as nullable in the object models. Hopefully that resolves these kinds of issues once and for all (related #52).

You can get the new Coinbase v5.0.8 bits here: https://www.nuget.org/packages/Coinbase/5.0.8

Thanks again for your help!
Brian

🚶 😎 "So don't delay... act now supplies are running out..."

@bheesbeen
Copy link
Contributor Author

bheesbeen commented Feb 28, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants