Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds unwrap_np_float to all prediction calls #4229

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Jan 27, 2025

To convert predicted values from the underlying numpy model to python floats.

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator
PSU Insights

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@conbrad conbrad requested review from dgboss and brettedw January 27, 2025 21:38
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.61%. Comparing base (6f2e21f) to head (5bd67d7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
api/app/weather_models/machine_learning.py 80.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4229   +/-   ##
=======================================
  Coverage   80.61%   80.61%           
=======================================
  Files         312      312           
  Lines       11993    11995    +2     
  Branches      540      540           
=======================================
+ Hits         9668     9670    +2     
  Misses       2137     2137           
  Partials      188      188           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@conbrad conbrad temporarily deployed to production January 27, 2025 22:00 Inactive
@conbrad conbrad merged commit 1a2fa03 into main Jan 27, 2025
26 checks passed
@conbrad conbrad deleted the task/fix-numpy-float-conversion branch January 27, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants