Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added environment variables for MSSQL #64

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Added environment variables for MSSQL #64

merged 2 commits into from
Dec 15, 2022

Conversation

devin-aot
Copy link
Contributor

@devin-aot devin-aot commented Dec 15, 2022 •
edited
Loading

Description

Added environment variables for MSSQL.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Ran docker compose up -d and connected to mssql db

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

cberg-aot
cberg-aot previously approved these changes Dec 15, 2022
View reviewed changes
Copy link
Collaborator

@cberg-aot cberg-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

krishnan-aot
krishnan-aot approved these changes Dec 15, 2022
View reviewed changes
Copy link
Collaborator

@krishnan-aot krishnan-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@devin-aot devin-aot changed the title Added environment variables for MSSQL and added sample.env's Added environment variables for MSSQL Dec 15, 2022
@devin-aot devin-aot merged commit 388df1f into main Dec 15, 2022
@devin-aot devin-aot deleted the fix/update_mssql_env_vars branch December 15, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnan-aot krishnan-aot krishnan-aot approved these changes

@cberg-aot cberg-aot cberg-aot left review comments

@gchauhan-aot gchauhan-aot Awaiting requested review from gchauhan-aot gchauhan-aot is a code owner

@john-fletcher-aot john-fletcher-aot Awaiting requested review from john-fletcher-aot john-fletcher-aot is a code owner

@praju-aot praju-aot Awaiting requested review from praju-aot praju-aot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devin-aot @krishnan-aot @cberg-aot