Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated docker compose #52

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Updated docker compose #52

merged 2 commits into from
Dec 13, 2022

Conversation

devin-aot
Copy link
Contributor

@devin-aot devin-aot commented Dec 13, 2022 •
edited by github-actions bot
Loading

Description

  • Updated docker compose yml to point to Dockerfiles for consistency between local development and deployments
  • Added mssql docker image to docker compose for local development

Referenced:

Add ddl files to the database/mssql/ddl folder and choose which one you want to be used in the start up script by updating the DDL_FILENAME variable in the dockerfile.

Run the following commands in a terminal to test:

docker ps -a
docker exec -it sql-server-db "bash"
/opt/mssql-tools/bin/sqlcmd -S localhost -U SA -P "YourStrong@Passw0rd"

Or with MS SQL Server Management Studio

image

Fixes ORV2-308

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@devin-aot devin-aot merged commit b85f519 into main Dec 13, 2022
@devin-aot devin-aot deleted the docker/update_docker_compose branch December 13, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnan-aot krishnan-aot krishnan-aot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devin-aot @krishnan-aot