Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-433 Refactored Custom Form component #175

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

devin-aot
Copy link
Contributor

@devin-aot devin-aot commented Feb 3, 2023

Description

Cleaned up code related to the custom select/input component
Added comments

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested validation on Power Unit form
  • Successfully added a power unit

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@devin-aot devin-aot temporarily deployed to dev February 3, 2023 20:16 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev February 3, 2023 20:16 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev February 3, 2023 20:16 — with GitHub Actions Inactive
@devin-aot devin-aot merged commit 3ae8571 into main Feb 3, 2023
@devin-aot devin-aot deleted the ORV2-433_refactor_form_components branch February 3, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants