Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-387 Testing Framework for Vehicles API #171

Merged
merged 9 commits into from
Feb 3, 2023
Merged

ORV2-387 Testing Framework for Vehicles API #171

merged 9 commits into from
Feb 3, 2023

Conversation

praju-aot
Copy link
Collaborator

@praju-aot praju-aot commented Feb 2, 2023

Description

  • Implement unit test and e2e framework for vehicles api
  • Added test cases for Power Units, Power Unit Types, Trailers and Trailer Types

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • npm run test
  • npm run test:e2e
  • Run docker compose run --build -d, verify container starts successfully
  • Test the swagger Apis at http://:5000/api

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.1% 6.1% Duplication

@praju-aot praju-aot temporarily deployed to dev February 2, 2023 22:16 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev February 2, 2023 22:16 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev February 2, 2023 22:16 — with GitHub Actions Inactive
@praju-aot
Copy link
Collaborator Author

Kindly ignore the sonar cloud gateway failure due to Code Duplication.
Code duplication due to object creations and similar unit test and e2e test cases for power units, power unit types, trailers, and trailer types

@john-fletcher-aot
Copy link
Collaborator

I'm not the best to comment on the code but in Garima's absence I reviewed it and ran all local tests and all looks good.

Copy link
Collaborator

@john-fletcher-aot john-fletcher-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@praju-aot praju-aot merged commit fe7eafb into main Feb 3, 2023
@praju-aot praju-aot deleted the ORV2-387 branch February 3, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants