Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-433 Company Profile Form #169

Merged
merged 18 commits into from
Feb 2, 2023
Merged

ORV2-433 Company Profile Form #169

merged 18 commits into from
Feb 2, 2023

Conversation

devin-aot
Copy link
Contributor

@devin-aot devin-aot commented Jan 31, 2023

Description

  • Completed initial draft of Company Profile Form
  • Made CountryAndProvince dropdown components Generic for powerunits and profile
    (will update the fields once I get the API format)
  • Made Form components Generic for powerunits and profile
    (left some original PowerUnit input boxes for comparison)
  • Updated styles for Manage Vehicles "add powerunit" story - mainly the form component

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Checked validations for Company Info
  • Added a Power Unit to the Vehicle Inventory
  • Checked validations for Power Unit Form

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

  • Can probably ignore the code duplication error from SonarCloud as its complaining about similar Phone Number fields

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@devin-aot devin-aot temporarily deployed to dev January 31, 2023 22:44 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev January 31, 2023 22:44 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev January 31, 2023 22:44 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev January 31, 2023 23:17 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev January 31, 2023 23:17 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev January 31, 2023 23:17 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev February 1, 2023 00:28 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev February 1, 2023 00:28 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev February 1, 2023 00:28 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev February 1, 2023 00:35 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev February 1, 2023 00:35 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev February 1, 2023 00:35 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev February 1, 2023 01:17 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev February 1, 2023 01:17 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev February 1, 2023 01:17 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev February 1, 2023 01:37 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev February 1, 2023 01:37 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev February 1, 2023 01:37 — with GitHub Actions Inactive
@devin-aot devin-aot marked this pull request as ready for review February 1, 2023 01:37
@devin-aot devin-aot marked this pull request as draft February 1, 2023 16:00
@devin-aot devin-aot temporarily deployed to dev February 1, 2023 17:06 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev February 1, 2023 17:06 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev February 1, 2023 17:06 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev February 1, 2023 21:43 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev February 1, 2023 21:43 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev February 1, 2023 21:43 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.9% 5.9% Duplication

@devin-aot devin-aot temporarily deployed to dev February 2, 2023 18:32 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev February 2, 2023 18:32 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev February 2, 2023 18:32 — with GitHub Actions Inactive
@devin-aot devin-aot marked this pull request as ready for review February 2, 2023 18:45
Copy link
Collaborator

@krishnan-aot krishnan-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@devin-aot devin-aot merged commit 210b9cd into main Feb 2, 2023
@devin-aot devin-aot deleted the ORV2-433 branch February 2, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants