Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-2991 - Fix application form/review incorrect datetime display #1659

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

zgong-gov
Copy link
Collaborator

@zgong-gov zgong-gov commented Nov 8, 2024

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

  • Fix datetime conversion to local datetime issue
  • Ensure proper usage of date helper methods in each of the components

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Ensure that all datetime related information is displayed correctly throughout the application
  • Try creating an application, and set the start date to be Nov. 12, 2024 with duration of 150 days, and observe that the expiry date should be Apr. 10, 2025, and after filling out the rest of the required fields and clicking continue, the application review page should display the same start date and expiry date (with no changes). Updating an application should yield the same start date and expiry date on both the form and review pages.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Copy link

sonarqubecloud bot commented Nov 8, 2024

Copy link

sonarqubecloud bot commented Nov 8, 2024

Copy link

sonarqubecloud bot commented Nov 8, 2024

Copy link

sonarqubecloud bot commented Nov 8, 2024

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
37.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Nov 8, 2024

@zgong-gov zgong-gov merged commit c57aedc into main Nov 8, 2024
22 of 23 checks passed
@zgong-gov zgong-gov deleted the ORV2-2991 branch November 8, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants