Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-2759 - FE: Staff Approve Application in the Queue #1652

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Conversation

glen-aot
Copy link
Collaborator

@glen-aot glen-aot commented Oct 25, 2024

Description

add invalid start/expiry date banner to permit review

Fixes #ORV2-2759

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Copy link

sonarcloud bot commented Oct 30, 2024

Copy link

sonarcloud bot commented Oct 30, 2024

Copy link

sonarcloud bot commented Oct 30, 2024

Copy link

sonarcloud bot commented Oct 30, 2024

Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
68.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@glen-aot glen-aot merged commit 99e2712 into main Oct 31, 2024
22 of 23 checks passed
@glen-aot glen-aot deleted the ORV2-2759 branch October 31, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants