Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-386 Adjustments to power unit form fields #165

Merged
merged 8 commits into from
Jan 30, 2023
Merged

Conversation

krishnan-aot
Copy link
Collaborator

@krishnan-aot krishnan-aot commented Jan 26, 2023

Description

  • Adding max length and correcting required fields in Power Unit form
  • onRouteBc to onRouteBC

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@krishnan-aot krishnan-aot temporarily deployed to dev January 26, 2023 18:05 — with GitHub Actions Inactive
@krishnan-aot krishnan-aot temporarily deployed to dev January 26, 2023 18:05 — with GitHub Actions Inactive
@krishnan-aot krishnan-aot temporarily deployed to dev January 26, 2023 18:05 — with GitHub Actions Inactive
@krishnan-aot krishnan-aot temporarily deployed to dev January 26, 2023 19:40 — with GitHub Actions Inactive
@krishnan-aot krishnan-aot temporarily deployed to dev January 26, 2023 19:40 — with GitHub Actions Inactive
@krishnan-aot krishnan-aot temporarily deployed to dev January 26, 2023 19:40 — with GitHub Actions Inactive
@krishnan-aot krishnan-aot temporarily deployed to dev January 26, 2023 20:03 — with GitHub Actions Inactive
@krishnan-aot krishnan-aot temporarily deployed to dev January 26, 2023 20:03 — with GitHub Actions Inactive
@krishnan-aot krishnan-aot temporarily deployed to dev January 26, 2023 20:03 — with GitHub Actions Inactive
Copy link
Contributor

@devin-aot devin-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Make' should be 20 char max as per the specs.

Is data type validation TBD? (numeric, alphanumeric, etc for fields)

Otherwise I have checked the fields for the mandatory/max length validations and it looks good.

Thanks for updating the onRouteBC casing

@krishnan-aot krishnan-aot temporarily deployed to dev January 27, 2023 17:53 — with GitHub Actions Inactive
@krishnan-aot krishnan-aot temporarily deployed to dev January 27, 2023 17:53 — with GitHub Actions Inactive
@krishnan-aot krishnan-aot temporarily deployed to dev January 27, 2023 17:53 — with GitHub Actions Inactive
@krishnan-aot krishnan-aot temporarily deployed to dev January 27, 2023 18:06 — with GitHub Actions Inactive
@krishnan-aot krishnan-aot temporarily deployed to dev January 27, 2023 18:06 — with GitHub Actions Inactive
@krishnan-aot krishnan-aot temporarily deployed to dev January 27, 2023 18:06 — with GitHub Actions Inactive
@krishnan-aot krishnan-aot marked this pull request as draft January 27, 2023 20:56
@sonarcloud
Copy link

sonarcloud bot commented Jan 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@krishnan-aot krishnan-aot temporarily deployed to dev January 27, 2023 20:57 — with GitHub Actions Inactive
@krishnan-aot krishnan-aot temporarily deployed to dev January 27, 2023 20:57 — with GitHub Actions Inactive
@krishnan-aot krishnan-aot temporarily deployed to dev January 27, 2023 20:57 — with GitHub Actions Inactive
@krishnan-aot
Copy link
Collaborator Author

'Make' should be 20 char max as per the specs.

Is data type validation TBD? (numeric, alphanumeric, etc for fields)

Otherwise I have checked the fields for the mandatory/max length validations and it looks good.

Thanks for updating the onRouteBC casing

The data type validations will happen later when the backend ticket does it. We'll create a parallel ticket for frontend at that time to deal with this.

@krishnan-aot krishnan-aot marked this pull request as ready for review January 30, 2023 16:44
@devin-aot devin-aot merged commit 41a9705 into main Jan 30, 2023
@devin-aot devin-aot deleted the ORV2-386-adjustments branch January 30, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants