-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ORV2-386 Adjustments to power unit form fields #165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Make' should be 20 char max as per the specs.
Is data type validation TBD? (numeric, alphanumeric, etc for fields)
Otherwise I have checked the fields for the mandatory/max length validations and it looks good.
Thanks for updating the onRouteBC casing
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
The data type validations will happen later when the backend ticket does it. We'll create a parallel ticket for frontend at that time to deal with this. |
Description
onRouteBc
toonRouteBC
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Frontend available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Frontend available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow