ORV2-2338 Bug Fix

[zgong-gov]

Description

• Fixes infinite loop bug for permit application form
• Fixes incorrect display and selection options for duration, conditions, and vehicle options and subtype options
• Refactoring and reorganization of code
• Adding various helper methods and hooks to memoize and handle checking equality for reference/object/array types
• Remove unused (and potentially problematic) objects/lists from useApplicationFormContext that are not directly used by the form and inputs

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Make sure that all duration, conditions, and vehicle selection (and subtype selection) behave properly for the application and amendment forms, and that saving applications/permits will also yield consistently correct data when editing again.

Checklist

• I have read the CONTRIBUTING doc
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have already been accepted and merged

Further comments

---

Thanks for the PR!

Deployments, as required, will be available below:

• Frontend
• Vehicles
• Dops
• Policy
• Scheduler

Please create PRs in draft mode. Mark as ready to enable:

• Analysis Workflow

After merge, new images are promoted to:

• Merge Workflow

[sonarcloud]

Quality Gate passed for 'onroutebc_policy'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sonarcloud]

Quality Gate passed for 'onroutebc_scheduler'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sonarcloud]

Quality Gate passed for 'onroutebc dops'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sonarcloud]

Quality Gate passed for 'onroutebc vehicles'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sonarcloud]

Quality Gate failed for 'onroutebc frontend'

Failed conditions
29.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud