Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updates to CSV import and export for size dimension set into policy engine #1639

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

john-fletcher-aot
Copy link
Collaborator

@john-fletcher-aot john-fletcher-aot commented Oct 16, 2024

Description

Updates to CSV import and export for size dimension set into policy engine

Fixes # ORV2-2858

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Ran all existing tests, confirm passed
  • Imported csv from Excel into policy engine, re-exported to CSV and confirmed files are identical

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Copy link

sonarcloud bot commented Oct 16, 2024

Copy link

sonarcloud bot commented Oct 16, 2024

Copy link

sonarcloud bot commented Oct 16, 2024

Copy link

sonarcloud bot commented Oct 16, 2024

Copy link

sonarcloud bot commented Oct 16, 2024

@john-fletcher-aot john-fletcher-aot merged commit ab0fb51 into main Oct 17, 2024
23 checks passed
@john-fletcher-aot john-fletcher-aot deleted the ORV2-2858 branch October 17, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants