Skip to content

ORV-2748 - Voided permits showing as expired in global search #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Conversation

glen-aot
Copy link
Collaborator

@glen-aot glen-aot commented Oct 15, 2024

Description

update PermitSearchResultColumnDef to show PermitStatusChip with Void status if permit is both expired and voided

Fixes #ORV2-2748

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

… status if permit is both expired and voided
Copy link

Copy link

Copy link

Copy link

Copy link

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
16.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@glen-aot glen-aot merged commit 8872a39 into main Oct 15, 2024
22 of 23 checks passed
@glen-aot glen-aot deleted the ORV2-2748 branch October 15, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants