Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORV2-2834 - FE: Update: Change Start Application Menu and Steps #1635

Merged
merged 19 commits into from
Oct 21, 2024
Merged

ORV2-2834 - FE: Update: Change Start Application Menu and Steps #1635

merged 19 commits into from
Oct 21, 2024

Conversation

glen-aot
Copy link
Collaborator

@glen-aot glen-aot commented Oct 11, 2024 •
edited by github-actions bot
Loading

Description

Implements the nested dropdown menu for selecting a permit application type.

Fixes #ORV2-2834

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@glen-aot
Merge remote-tracking branch 'origin/main' into ORV2-2834
fde34c2
@glen-aot
resolve circular import between permits/constants/constants.ts, permi…
0d857a2 
…ts/types/PermitCategory.ts and permits/types/PermitType.ts by moving list of permit types from constants to newly created permitLists.ts
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Passed Quality Gate passed for 'onroutebc_scheduler'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Passed Quality Gate passed for 'onroutebc_policy'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Passed Quality Gate passed for 'onroutebc dops'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Passed Quality Gate passed for 'onroutebc vehicles'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
52.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@glen-aot glen-aot merged commit 63b9ed9 into main Oct 21, 2024
22 of 23 checks passed
@glen-aot glen-aot deleted the ORV2-2834 branch October 21, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zgong-gov zgong-gov zgong-gov approved these changes

@krishnan-aot krishnan-aot Awaiting requested review from krishnan-aot krishnan-aot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glen-aot @zgong-gov