Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:ORV2-2922: GL Code Update #1632

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

praju-aot
Copy link
Collaborator

@praju-aot praju-aot commented Oct 9, 2024

Description

Configure GL Project code with respect to payment method type.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manual testing

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Configure GL Project code with respect to payment method type.
Copy link

sonarcloud bot commented Oct 9, 2024

Copy link

sonarcloud bot commented Oct 9, 2024

Copy link

sonarcloud bot commented Oct 9, 2024

Copy link

sonarcloud bot commented Oct 9, 2024

Copy link

sonarcloud bot commented Oct 9, 2024

Quality Gate Failed Quality Gate failed for 'onroutebc vehicles'

Failed conditions
21.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@praju-aot praju-aot merged commit a2d5b14 into main Oct 9, 2024
22 of 23 checks passed
@praju-aot praju-aot deleted the feature/ORV2-2922_GL_Code_Update branch October 9, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants