Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORV2 1504 Sonar Issue Fix #1597

Merged
merged 30 commits into from
Sep 16, 2024
Merged

ORV2 1504 Sonar Issue Fix #1597

merged 30 commits into from
Sep 16, 2024

Conversation

gchauhan-aot
Copy link
Collaborator

@gchauhan-aot gchauhan-aot commented Sep 13, 2024 •
edited by github-actions bot
Loading

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

zgong-gov and others added 30 commits August 29, 2024 10:53
@zgong-gov
Add helper method to set correct fee summary based on no-fee permit type
86cb3be
@zgong-gov
Merge branch 'main' into ORV2-1504
2482ba2
@gchauhan-aot
changes for no fee payment type
eed6d24
@zgong-gov
Use no-fee permit type fee calculation for application and shopping cart
4600126
@zgong-gov
Merge branch 'main' into ORV2-1504
53e4057
@zgong-gov
Merge branch 'ORV2-2766-be-apply-permit-no-fee' into ORV2-1504
9d5728c
@gchauhan-aot
Merge remote-tracking branch 'origin/main' into ORV2-2766-be-apply-pe…
0519ba8 
…rmit-no-fee
@gchauhan-aot
Merge remote-tracking branch 'origin/ORV2-1504' into ORV2-2766-be-app…
9364b6b 
…ly-permit-no-fee
@zgong-gov
Merge branch 'main' into ORV2-1504
e41d2cb
@zgong-gov
Merge branch 'ORV2-2766-be-apply-permit-no-fee' into ORV2-1504
50c87f7
@zgong-gov
Revert and remove unused feeSummary related logic
3fabd00
@zgong-gov
Merge branch 'main' into ORV2-1504
bb17467
@zgong-gov
Merge branch 'main' into ORV2-1504
608dedf
@zgong-gov
Handle amend refunds and void for no-fee permits
c394426
@gchauhan-aot
adding permit duration for shopping cart
d08a2a3
@zgong-gov
Adding duration to cart item
a7d3321
@zgong-gov
Merge branch 'be-shopping-cart-map-duration' into ORV2-1504, fix conf…
ea4ec9a 
…licts
@gchauhan-aot
Fixing no fee void issue
b2c4d05
@zgong-gov
Merge branch 'ORV2-2766-be-apply-permit-no-fee' into ORV2-1504
48cfd90
@zgong-gov
Merge branch 'main' into ORV2-1504
dc4537e
@gchauhan-aot
fixing no fee void permit issue
0a357ef
@zgong-gov
Merge branch 'ORV2-2766-be-apply-permit-no-fee' into ORV2-1504
56b3d5f
@zgong-gov
Revert amend refund amount calculation for no-fee flag scenarios
a2f98c9
@gchauhan-aot
fixing amendment issue for no fee
787dc16
@gchauhan-aot
Merge remote-tracking branch 'origin/ORV2-1504' into ORV2-2766-be-app…
fe75f11 
…ly-permit-no-fee
@gchauhan-aot
fixing amendment for no fee permit and formatting
ffb0f94
@gchauhan-aot
amendment fix
dbedecb
@gchauhan-aot
updating as per review comments
2b43804
@gchauhan-aot
resolving sonar issue
e621875
@gchauhan-aot
Merge remote-tracking branch 'origin/main' into ORV2-1504
2ee06ea 
# Conflicts:
#	frontend/src/features/permits/types/CartItem.ts
#	vehicles/src/modules/permit-application-payment/payment/payment.service.ts
@gchauhan-aot gchauhan-aot added dont review dont merge a branch for anything that shouldn't be merged (yet or ever) labels Sep 13, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 13, 2024

Quality Gate Passed Quality Gate passed for 'onroutebc_policy'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 13, 2024

Quality Gate Passed Quality Gate passed for 'onroutebc_scheduler'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 13, 2024

Quality Gate Passed Quality Gate passed for 'onroutebc dops'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 13, 2024

Quality Gate Passed Quality Gate passed for 'onroutebc frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 13, 2024

Quality Gate Passed Quality Gate passed for 'onroutebc vehicles'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@praju-aot praju-aot removed dont review dont merge a branch for anything that shouldn't be merged (yet or ever) labels Sep 16, 2024
@praju-aot praju-aot merged commit aeb7770 into main Sep 16, 2024
23 checks passed
@praju-aot praju-aot deleted the ORV2-1504 branch September 16, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praju-aot praju-aot praju-aot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gchauhan-aot @praju-aot @zgong-gov