ORV2-1504: Applying for no-fee permits

[zgong-gov]

Description

• Allow no-fee permit types to be used for all permits
• Application review page and shopping cart items show $0 for fee summary when no-fee flag enabled, and normal fees when flag disabled
• Amend refund works normally, except that permits with net amount of $0 gets refunded $0
• Void refund works normally, except that permits with net amount of $0 gets refunded $0

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Set the no-fee flag in special authorizations page, and create a new application. Verify that the fee summary on the application review and shopping cart page (and cart items) all show fee summary of $0
• Disable the no-fee flag in special authorizations page, and create a new application. Verify that the fee summary on the application review and shopping cart page (and cart items) all show correctly calculated (non-zero) fees
• Amend a permit several times by reducing its duration or changing other values, and observe that for any permit that was initially purchased with non-zero dollars, regardless of how the no-fee flag is toggled during this amend process, the proper refund amount will always be refunded (ie. reducing 90 day duration to 60 days for TROS always refunds $30, regardless of no-fee flag)
• Amend a permit paid with $0 several times by reducing its duration or changing other values, and observe that the refund amount is always $0, regardless of what values were changed for amend, and how the no-fee flag is toggled during this amend process
• Void a permit paid with $0 and observe that the refund amount is always $0, regardless of what the no-fee flag status is in, nor the duration of the permit
• Void a non-zero dollar permit, and observe that the original normal void behaviour still works as expected, regardless of the no-fee flag status

Checklist

• I have read the CONTRIBUTING doc
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have already been accepted and merged

Further comments

---

Thanks for the PR!

Deployments, as required, will be available below:

• Frontend
• Vehicles
• Dops
• Policy
• Scheduler

Please create PRs in draft mode. Mark as ready to enable:

• Analysis Workflow

After merge, new images are promoted to:

• Merge Workflow

[sonarcloud]

Quality Gate passed for 'onroutebc_scheduler'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sonarcloud]

Quality Gate passed for 'onroutebc_policy'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sonarcloud]

Quality Gate passed for 'onroutebc dops'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sonarcloud]

Quality Gate failed for 'onroutebc vehicles'

Failed conditions
7.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

[sonarcloud]

Quality Gate failed for 'onroutebc frontend'

Failed conditions
21.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

[praju-aot]

+1