Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-2682 - Staff Manage queue #1587

Merged
merged 4 commits into from
Sep 9, 2024
Merged

ORV2-2682 - Staff Manage queue #1587

merged 4 commits into from
Sep 9, 2024

Conversation

praju-aot
Copy link
Collaborator

@praju-aot praju-aot commented Sep 9, 2024

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Staff Manage Queue - Send Notification at the time of approval or rejection

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • npm run test
  • npm run test:e2e

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Copy link

sonarcloud bot commented Sep 9, 2024

@praju-aot praju-aot enabled auto-merge (squash) September 9, 2024 20:51
Copy link

sonarcloud bot commented Sep 9, 2024

Copy link

sonarcloud bot commented Sep 9, 2024

Quality Gate Failed Quality Gate failed for 'onroutebc dops'

Failed conditions
25.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Sep 9, 2024

Quality Gate Failed Quality Gate failed for 'onroutebc vehicles'

Failed conditions
4.9% Coverage on New Code (required ≥ 80%)
17.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Sep 9, 2024

@praju-aot praju-aot merged commit 318996f into main Sep 9, 2024
21 of 23 checks passed
@praju-aot praju-aot deleted the ORV2-2682 branch September 9, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants