Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-2692 Fixing User management and Vehicle query - data refresh #1576

Merged
merged 6 commits into from
Aug 30, 2024

Conversation

krishnan-aot
Copy link
Collaborator

@krishnan-aot krishnan-aot commented Aug 29, 2024

Description

  • Add gcTime property to vehicles and user management useQuery hooks. This is to prevent saving the form values in the cache and being reused instead of the form reflecting the latest values from the API response.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

User management:

  • Edit a user in the Manage Profile section and see if the data in the table updates correctly.
  • Edit the same user again and check if the form has the correct values reflecting the API response.

Vehicles:

  • Edit a vehicle (both power unit and trailer) in the Manage Vehicle section and see if the data in the table updates correctly.
  • Edit the same vehicle (both power unit and trailer) again and check if the form has the correct values reflecting the API response.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@krishnan-aot krishnan-aot added dont review dont merge a branch for anything that shouldn't be merged (yet or ever) labels Aug 29, 2024
@krishnan-aot krishnan-aot changed the title Fixing User management queries ORV2-2692 Fixing User management queries Aug 29, 2024
@krishnan-aot krishnan-aot removed dont review dont merge a branch for anything that shouldn't be merged (yet or ever) labels Aug 29, 2024
@krishnan-aot krishnan-aot changed the title ORV2-2692 Fixing User management queries ORV2-2692 Fixing User management and Vehicle query - data refresh Aug 29, 2024
@krishnan-aot krishnan-aot enabled auto-merge (squash) August 29, 2024 21:03
Copy link

sonarcloud bot commented Aug 30, 2024

Copy link

sonarcloud bot commented Aug 30, 2024

Copy link

sonarcloud bot commented Aug 30, 2024

Copy link

sonarcloud bot commented Aug 30, 2024

Copy link

sonarcloud bot commented Aug 30, 2024

@krishnan-aot krishnan-aot merged commit 777a531 into main Aug 30, 2024
23 checks passed
@krishnan-aot krishnan-aot deleted the userm branch August 30, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants