Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-2616 - Fix LOA bugs on FE #1560

Merged
merged 4 commits into from
Aug 27, 2024
Merged

ORV2-2616 - Fix LOA bugs on FE #1560

merged 4 commits into from
Aug 27, 2024

Conversation

zgong-gov
Copy link
Collaborator

@zgong-gov zgong-gov commented Aug 26, 2024

Description

  • Add delete dialog for deleting LOA document
  • Show notification snackbar for creating and updating LOAs

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Ensure that the appropriate notification snackbar shows up after successful edit/creation of an LOA
  • Ensure that the delete dialog appears when trying to delete an LOA document, as well as being able to cancel the delete action

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Copy link

sonarcloud bot commented Aug 27, 2024

Copy link

sonarcloud bot commented Aug 27, 2024

Copy link

sonarcloud bot commented Aug 27, 2024

Copy link

sonarcloud bot commented Aug 27, 2024

Copy link

sonarcloud bot commented Aug 27, 2024

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
25.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@zgong-gov zgong-gov merged commit 13b04e0 into main Aug 27, 2024
22 of 23 checks passed
@zgong-gov zgong-gov deleted the ORV2-2616 branch August 27, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants