Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-2685: added document on the way page when pdf file unavailable #1559

Merged
merged 8 commits into from
Sep 4, 2024

Conversation

bcgov-brwang
Copy link
Collaborator

@bcgov-brwang bcgov-brwang commented Aug 26, 2024

ORV2-2685: added document on the way page when pdf file unavailable

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

ORV2-2685: added document on the way page when pdf file unavailable
ORV2-2685: rework based on code review comments
ORV2-2685: removed handleViewPermitPdf
ORV2-2685: resolved build error
ORV2-2685: rework on some other code review comments
… array

ORV2-2685: update PermitSearchResultColumnDef to method instead of an array
ORV2-2685: fixed frontend build error
@bcgov-brwang bcgov-brwang enabled auto-merge (squash) September 4, 2024 20:37
Copy link

sonarcloud bot commented Sep 4, 2024

Copy link

sonarcloud bot commented Sep 4, 2024

Copy link

sonarcloud bot commented Sep 4, 2024

Copy link

sonarcloud bot commented Sep 4, 2024

Copy link

sonarcloud bot commented Sep 4, 2024

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
20.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@bcgov-brwang bcgov-brwang merged commit 0f08c8d into main Sep 4, 2024
22 of 23 checks passed
@bcgov-brwang bcgov-brwang deleted the ORV2-2685-2 branch September 4, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants