Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-399 Implementation Of Error handling Review Comments #155

Merged
merged 4 commits into from
Jan 24, 2023

Conversation

gchauhan-aot
Copy link
Collaborator

@gchauhan-aot gchauhan-aot commented Jan 24, 2023

Description

Implementation of review comments for error handling changes.
Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A: Unit testing done using postman
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@sonarcloud
Copy link

sonarcloud bot commented Jan 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gchauhan-aot gchauhan-aot temporarily deployed to dev January 24, 2023 00:29 — with GitHub Actions Inactive
@gchauhan-aot gchauhan-aot temporarily deployed to dev January 24, 2023 00:29 — with GitHub Actions Inactive
@gchauhan-aot gchauhan-aot temporarily deployed to dev January 24, 2023 00:29 — with GitHub Actions Inactive
@krishnan-aot krishnan-aot merged commit 5ec4552 into main Jan 24, 2023
@krishnan-aot krishnan-aot deleted the ORV2-399 branch January 24, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants