Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated credit account sequence to avoid duplication #1526

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

john-fletcher-aot
Copy link
Collaborator

@john-fletcher-aot john-fletcher-aot commented Aug 2, 2024

Description

Changed credit account sequence and length of credit account number so we can use longer unique numbers in dev and test to avoid issues with account number duplication in CFS.

Fixes # ORV2-2605

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Standard SQL test written for version 38, ran without errors
  • Reviewed database manually in SSMS to verify changes were successful
  • Manually reverted changes using utility scripts after sample data loaded into local SQL Server instance

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Fixed some other unrelated SQL tests as part of this PR


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Copy link

sonarcloud bot commented Aug 8, 2024

Copy link

sonarcloud bot commented Aug 8, 2024

Copy link

sonarcloud bot commented Aug 8, 2024

Copy link

sonarcloud bot commented Aug 8, 2024

Copy link

sonarcloud bot commented Aug 8, 2024

@john-fletcher-aot john-fletcher-aot merged commit b4f7db9 into main Aug 8, 2024
23 checks passed
@john-fletcher-aot john-fletcher-aot deleted the ORV2-2605 branch August 8, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants