Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-2571, 2572, 2573 Credit Account - API split integration #1522

Merged
merged 14 commits into from
Aug 1, 2024
Merged

Conversation

krishnan-aot
Copy link
Collaborator

@krishnan-aot krishnan-aot commented Jul 29, 2024

Description

  • Credit Account API split alignment
  • Credit Account Granular roles in alignment with Permissions Matrix
  • Fixing queryClient setup. Every time the App component rerenders, the query client object was a net new one and previous cache was thrown away. This was a an intermittent issue to reproduce previously but it finally reared its head once again and the new setup ensures this isn't a problem anymore.
  • Splitting CreditAccount component into View and Add components.

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Local deploymeny
  • Comparison with permission matrix

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@krishnan-aot krishnan-aot added dont review dont merge a branch for anything that shouldn't be merged (yet or ever) labels Jul 29, 2024
@krishnan-aot krishnan-aot removed dont review dont merge a branch for anything that shouldn't be merged (yet or ever) labels Jul 30, 2024
@krishnan-aot krishnan-aot changed the title Credit Account - API split integration ORV2-2571, 2572, 2573 Credit Account - API split integration Jul 30, 2024
Copy link

sonarcloud bot commented Jul 30, 2024

Copy link

sonarcloud bot commented Jul 30, 2024

Copy link

sonarcloud bot commented Jul 30, 2024

Copy link

sonarcloud bot commented Jul 30, 2024

Copy link

sonarcloud bot commented Jul 30, 2024

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
26.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@krishnan-aot krishnan-aot added the dont merge a branch for anything that shouldn't be merged (yet or ever) label Jul 31, 2024
frontend/src/App.tsx Show resolved Hide resolved
@krishnan-aot krishnan-aot added dont merge a branch for anything that shouldn't be merged (yet or ever) and removed dont merge a branch for anything that shouldn't be merged (yet or ever) labels Jul 31, 2024
@krishnan-aot krishnan-aot merged commit a166812 into main Aug 1, 2024
22 of 23 checks passed
@krishnan-aot krishnan-aot deleted the cff branch August 1, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants