Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-2577: FE: Staff Accept Cash, Cheque, PoS and GA Payment Methods #1521

Merged
merged 11 commits into from
Aug 6, 2024

Conversation

glen-aot
Copy link
Collaborator

@glen-aot glen-aot commented Jul 29, 2024

Description

Adds "In-person at a Provincial Permit Centre" and "In-person at a Service BC Office (GA)" payment options when paying for a permit

Fixes #ORV2-2577

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@krishnan-aot krishnan-aot added the dont merge a branch for anything that shouldn't be merged (yet or ever) label Jul 29, 2024
…nd remove duplicate margin-right declaration
Copy link

sonarcloud bot commented Aug 6, 2024

Copy link

sonarcloud bot commented Aug 6, 2024

Copy link

sonarcloud bot commented Aug 6, 2024

Copy link

sonarcloud bot commented Aug 6, 2024

Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
25.9% Coverage on New Code (required ≥ 80%)
5.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@glen-aot glen-aot removed the dont merge a branch for anything that shouldn't be merged (yet or ever) label Aug 6, 2024
@glen-aot glen-aot merged commit b54ec99 into main Aug 6, 2024
22 of 23 checks passed
@glen-aot glen-aot deleted the ORV2-2577 branch August 6, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants