Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ORV2-2542 ORV2-2543 ORV2-2544 Role based access to Credit Account apis and refactoring #1517

Merged
merged 6 commits into from
Jul 25, 2024

Conversation

praju-aot
Copy link
Collaborator

@praju-aot praju-aot commented Jul 25, 2024

Description

ORV2-2542 ORV2-2543 ORV2-2544

image

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manual Testing
  • npm run test
  • npm run test:e2e

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@krishnan-aot krishnan-aot added the dont merge a branch for anything that shouldn't be merged (yet or ever) label Jul 25, 2024
@praju-aot praju-aot removed the dont merge a branch for anything that shouldn't be merged (yet or ever) label Jul 25, 2024
Copy link

sonarcloud bot commented Jul 25, 2024

Copy link

sonarcloud bot commented Jul 25, 2024

Copy link

sonarcloud bot commented Jul 25, 2024

Copy link

sonarcloud bot commented Jul 25, 2024

Quality Gate Failed Quality Gate failed for 'onroutebc vehicles'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
6.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jul 25, 2024

@praju-aot praju-aot merged commit 89f3762 into main Jul 25, 2024
21 of 22 checks passed
@praju-aot praju-aot deleted the ORV2-2542-v2 branch July 25, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants