Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Policy engine cost calculations and vehicle configuration functions #1508

Merged
merged 12 commits into from
Jul 29, 2024

Conversation

john-fletcher-aot
Copy link
Collaborator

@john-fletcher-aot john-fletcher-aot commented Jul 22, 2024

Description

Add configurable cost calculation routine to permit validation. Add default cost calculation for TROS, TROW, and STOS permit types in master sample policy config.

Add functions to retrieve next available vehicles for a configuration for a size dimension permit, and to validate configurations against policy.

Fixes # ORV2-2226

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • New unit tests added for all new functions
  • Confirm existing unit tests still pass

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

NPM package has not yet been version bumped and published. Once PR merged to main, minor version will be bumped to 0.2.0 and package will be published.


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Copy link

sonarcloud bot commented Jul 26, 2024

Copy link

sonarcloud bot commented Jul 26, 2024

Copy link

sonarcloud bot commented Jul 26, 2024

Copy link

sonarcloud bot commented Jul 26, 2024

Copy link

sonarcloud bot commented Jul 26, 2024

@john-fletcher-aot john-fletcher-aot merged commit 6eb9153 into main Jul 29, 2024
23 checks passed
@john-fletcher-aot john-fletcher-aot deleted the ORV2-2226 branch July 29, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants