Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-2293 - Hide 'Remove User' button for credit account users in UserTable #1487

Merged
merged 44 commits into from
Jul 16, 2024

Conversation

glen-aot
Copy link
Collaborator

@glen-aot glen-aot commented Jul 16, 2024

Description

Per the design, the 'Remove User' button should be hidden when the acting company is not the credit account holder.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

glen-aot and others added 30 commits May 16, 2024 12:16
Copy link

sonarcloud bot commented Jul 16, 2024

@glen-aot glen-aot merged commit cdc1d7a into main Jul 16, 2024
19 checks passed
@glen-aot glen-aot deleted the ORV2-2293 branch July 16, 2024 16:32
@glen-aot glen-aot restored the ORV2-2293 branch July 16, 2024 16:32
@DerekRoberts DerekRoberts deleted the ORV2-2293 branch July 23, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants