Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated 'Add Vehicle' button #148

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Updated 'Add Vehicle' button #148

merged 2 commits into from
Jan 20, 2023

Conversation

devin-aot
Copy link
Contributor

@devin-aot devin-aot commented Jan 20, 2023

Description

Updated 'Add Vehicle' button to have a dropdown for PowerUnits and Trailers

Did not implement functionality for showing a Trailer form,

Used code from: https://mui.com/material-ui/react-menu/#menulist-composition

Modified the z-index of menulist

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • npm start
  • click 'Add Vehicle' -> click 'Add PowerUnit' (form should show)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

krishnan-aot
krishnan-aot previously approved these changes Jan 20, 2023
Copy link
Collaborator

@krishnan-aot krishnan-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@devin-aot devin-aot temporarily deployed to dev January 20, 2023 22:06 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev January 20, 2023 22:06 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev January 20, 2023 22:06 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Jan 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@devin-aot devin-aot temporarily deployed to dev January 20, 2023 22:15 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev January 20, 2023 22:15 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev January 20, 2023 22:15 — with GitHub Actions Inactive
@devin-aot devin-aot merged commit 258ca59 into main Jan 20, 2023
@devin-aot devin-aot deleted the feat/add_vehicle_button branch January 20, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants