Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create initial schema for manage profiles feature #147

Merged
merged 11 commits into from
Jan 23, 2023
Merged

Create initial schema for manage profiles feature #147

merged 11 commits into from
Jan 23, 2023

Conversation

john-fletcher-aot
Copy link
Collaborator

@john-fletcher-aot john-fletcher-aot commented Jan 19, 2023

Description

Added 9 tables to the ORBC database in a v_3 ddl which is run automatically on Docker build for local development.

The tables have already been published (using the same DDL scripts) in the hosted MOTI ORBC_DEV database so they are as of the time of this PR in sync with this branch.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update (note, full documentation on the SQL process is scheduled for next sprint)

How Has This Been Tested?

  • Created basic automated test for local development to verify the tables are created successfully - this runs whenever the local Docker SQL db is spun up, verified the tests were successful in the SQL Server console in Docker.
  • Manual verification that the tables are created using SQL Server Management Studio

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

The schema was designed in consultation with the MOTI DA and the ORBC development team, and reflects business requirements elicited during regularly-scheduled story discovery sessions.

Requirements from MOTI DA for audit columns have been respected. Some initial decisions have been made with respect to object relationships, column naming, and foreign key constraints that are open to change as needed (so this schema is not to be considered final).


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@john-fletcher-aot john-fletcher-aot temporarily deployed to dev January 19, 2023 23:49 — with GitHub Actions Inactive
@john-fletcher-aot john-fletcher-aot temporarily deployed to dev January 19, 2023 23:49 — with GitHub Actions Inactive
@john-fletcher-aot john-fletcher-aot temporarily deployed to dev January 19, 2023 23:49 — with GitHub Actions Inactive
Copy link
Collaborator

@gchauhan-aot gchauhan-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.

@praju-aot praju-aot merged commit 4d698cb into main Jan 23, 2023
@praju-aot praju-aot deleted the ORV2-366 branch January 23, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants