Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ORV2-2532 Proceed to Route Handler if one of the guard validates successfully #1460

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

praju-aot
Copy link
Collaborator

@praju-aot praju-aot commented Jul 5, 2024

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

fix: ORV2-2532 - The application should validate guards and proceed to route handler if at least one of them succeeds.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • npm run test
  • npm run test:e2e
  • Purchase a permit
  • swagger

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

…o route handler if at least one of them succeeds.
Copy link

sonarcloud bot commented Jul 5, 2024

Quality Gate Failed Quality Gate failed for 'onroutebc dops'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jul 5, 2024

Quality Gate Failed Quality Gate failed for 'onroutebc vehicles'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@gchauhan-aot gchauhan-aot merged commit 7844505 into main Jul 5, 2024
16 of 18 checks passed
@gchauhan-aot gchauhan-aot deleted the ORV2-2532 branch July 5, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants