ORV2-394: Error handling changes for all vehicle apis #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP and Fallback Filter
Error Handling Changes for Power Unit API
Power unit types , trailer and trailer type
PowerUnit PowerUnit Type Trailer Trailer Type
# Conflicts:[Resolved] # backend/vehicles/src/power-unit-types/power-unit-types.controller.ts # backend/vehicles/src/power-unit-types/power-unit-types.service.ts # backend/vehicles/src/power-units/power-units.controller.ts # backend/vehicles/src/trailer-types/trailer-types.controller.ts # backend/vehicles/src/trailer-types/trailer-types.service.ts # backend/vehicles/src/trailers/trailers.controller.ts
# Conflicts:[Resolved] # backend/vehicles/src/power-unit-types/power-unit-types.controller.ts # backend/vehicles/src/power-unit-types/power-unit-types.service.ts # backend/vehicles/src/power-units/power-units.controller.ts # backend/vehicles/src/power-units/power-units.service.ts # backend/vehicles/src/trailer-types/trailer-types.controller.ts # backend/vehicles/src/trailer-types/trailer-types.service.ts # backend/vehicles/src/trailers/trailers.controller.ts # backend/vehicles/src/trailers/trailers.service.ts
backend/vehicles/src/power-unit-types/power-unit-types.controller.ts
Outdated
Show resolved
Hide resolved
backend/vehicles/src/power-unit-types/power-unit-types.controller.ts
Outdated
Show resolved
Hide resolved
john-fletcher-aot
previously approved these changes
Jan 20, 2023
updating error messages removing error handling from findAll
|
Kudos, SonarCloud Quality Gate passed!
|
krishnan-aot
approved these changes
Jan 20, 2023
|
After having a conversation with the dev team, there'll be more changes to the error responses here and will be part of a later PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change includes common error handling code and error handling implementation for all vehicle APIs.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Frontend available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow