Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-2464: Refactor and update UI and hooks for all vehicle related components #1448

Merged
merged 13 commits into from
Jun 28, 2024

Conversation

zgong-gov
Copy link
Collaborator

@zgong-gov zgong-gov commented Jun 27, 2024

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

  • Refactored Vehicles table and form components UI and styling based on client feedback
  • Renamed and refactored various files, methods, and hooks to improve naming conventions and organization
  • Moved delete vehicle method into hook, and fixed small bugs with some vehicle-related hooks (eg. passing companyId when calling vehicle endpoints)
  • Reworked permit vehicle details form section component
  • Improved styling for all table row actions

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Go through all vehicle-related use cases and ensure that all functionality still works properly.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Copy link

sonarcloud bot commented Jun 27, 2024

Copy link

sonarcloud bot commented Jun 27, 2024

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
57.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@zgong-gov zgong-gov merged commit 988fa3d into main Jun 28, 2024
17 of 18 checks passed
@zgong-gov zgong-gov deleted the ORV2-2464 branch June 28, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants