generated from bcgov/quickstart-openshift
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orv2 387 - Decouples Response and Request DTOs as part of best practices #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iler codes uppercase
… Unit Types and Trailer Types
…k to province, make 3NF
praju-aot
changed the title
Orv2 387
Orv2 387 - Decouples Response and Request DTOs as part of best practices
Jan 19, 2023
Please ignore the Code Duplication due to entity and dto |
backend/vehicles/src/power-unit-types/dto/request/create-power-unit-type.dto.ts
Outdated
Show resolved
Hide resolved
backend/vehicles/src/power-unit-types/dto/response/read-power-unit-type.dto.ts
Outdated
Show resolved
Hide resolved
backend/vehicles/src/trailer-types/dto/request/create-trailer-type.dto.ts
Show resolved
Hide resolved
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
krishnan-aot
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Run docker compose run --build -d, verify container starts successfully
Test the swagger Apis at http://:5000/api
Checklist
Further comments
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Frontend available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Frontend available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow