Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-2294 Backend API - Create Credit Account #1438

Merged
merged 57 commits into from
Jun 20, 2024
Merged

ORV2-2294 Backend API - Create Credit Account #1438

merged 57 commits into from
Jun 20, 2024

Conversation

krishnan-aot
Copy link
Collaborator

@krishnan-aot krishnan-aot commented Jun 18, 2024

Description

  • The POST endpoint for creating a credit account
  • The feature flag guard to check and allow a piece of functionality behind a feature flag.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@krishnan-aot krishnan-aot added the dont merge a branch for anything that shouldn't be merged (yet or ever) label Jun 18, 2024
@krishnan-aot
Copy link
Collaborator Author

Waiting for vault to be updated with some values. Till then, the deployment will not succeed.

Copy link

sonarcloud bot commented Jun 20, 2024

Copy link

sonarcloud bot commented Jun 20, 2024

Quality Gate Failed Quality Gate failed for 'onroutebc vehicles'

Failed conditions
0.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@praju-aot praju-aot removed the dont merge a branch for anything that shouldn't be merged (yet or ever) label Jun 20, 2024
@krishnan-aot krishnan-aot merged commit 080725f into main Jun 20, 2024
18 of 19 checks passed
@krishnan-aot krishnan-aot deleted the credit branch June 20, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants