Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: BCGOV fax implementation #1437

Merged
merged 3 commits into from
Jun 18, 2024
Merged

feat: BCGOV fax implementation #1437

merged 3 commits into from
Jun 18, 2024

Conversation

praju-aot
Copy link
Collaborator

@praju-aot praju-aot commented Jun 18, 2024

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

ORV2-1219 - Fax the permit and receipt PDF at time of issuance and resend notification

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • npm run test
  • npm run test:e2e

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@praju-aot praju-aot changed the title BCGOV fax implementation feat: BCGOV fax implementation Jun 18, 2024
Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Failed Quality Gate failed for 'onroutebc vehicles'

Failed conditions
10.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Failed Quality Gate failed for 'onroutebc dops'

Failed conditions
8.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@praju-aot praju-aot merged commit 04d16de into main Jun 18, 2024
17 of 19 checks passed
@praju-aot praju-aot deleted the fax branch June 18, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants