Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2 387 - Fixes in PowerUnit and Trailer response object #143

Merged
merged 19 commits into from
Jan 19, 2023
Merged

Conversation

praju-aot
Copy link
Collaborator

@praju-aot praju-aot commented Jan 19, 2023

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

  1. Backend changes to support DB level changes of Province Table
  2. Added the missing Created Date attribute to PowerUnit and Trailer Response Object

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Run docker compose run --build -d, verify container starts successfully
Test the swagger Apis at http://:5000/api

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
9.7% 9.7% Duplication

@praju-aot praju-aot temporarily deployed to dev January 19, 2023 03:24 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev January 19, 2023 03:24 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev January 19, 2023 03:24 — with GitHub Actions Inactive
@praju-aot
Copy link
Collaborator Author

Sonar Cloud - Code Duplication is for DTO and entity objects

Copy link
Collaborator

@krishnan-aot krishnan-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@praju-aot praju-aot merged commit 88ac0cc into main Jan 19, 2023
@praju-aot praju-aot deleted the ORV2-387 branch January 19, 2023 18:06
@praju-aot praju-aot restored the ORV2-387 branch January 19, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants