-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orv2 387 #142
Orv2 387 #142
Conversation
…iler codes uppercase
… Unit Types and Trailer Types
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Code duplication arises from the DTO objects and entity objects having the same fields which is a conscious design decision we made for separation of concern. So, the code duplication report here isn't a real concern for us. |
Description
Request and Response Object has been simplified for integration with front end.
Custom auto-mapper was implemented so that entities are not returned as resources.
Primary key of Power Unit Types and Trailer Types were changed from autogenerated fields to 7 digit alphanumeric code.
Primary Key of Province and Country were changed to 2 digit alpha code
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Run docker compose run --build -d, verify container starts successfully
Test the swagger Apis at http://:5000/api
Checklist
Further comments
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Frontend available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow