Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orv2 387 #142

Merged
merged 12 commits into from
Jan 18, 2023
Merged

Orv2 387 #142

merged 12 commits into from
Jan 18, 2023

Conversation

praju-aot
Copy link
Collaborator

@praju-aot praju-aot commented Jan 18, 2023

Description

Request and Response Object has been simplified for integration with front end.
Custom auto-mapper was implemented so that entities are not returned as resources.
Primary key of Power Unit Types and Trailer Types were changed from autogenerated fields to 7 digit alphanumeric code.
Primary Key of Province and Country were changed to 2 digit alpha code

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Run docker compose run --build -d, verify container starts successfully
Test the swagger Apis at http://:5000/api

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@praju-aot praju-aot temporarily deployed to dev January 18, 2023 00:33 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev January 18, 2023 00:33 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev January 18, 2023 00:33 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev January 18, 2023 17:17 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev January 18, 2023 17:17 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev January 18, 2023 17:17 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
15.5% 15.5% Duplication

@praju-aot praju-aot temporarily deployed to dev January 18, 2023 17:39 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev January 18, 2023 17:39 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev January 18, 2023 17:39 — with GitHub Actions Inactive
Copy link
Collaborator

@krishnan-aot krishnan-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@krishnan-aot
Copy link
Collaborator

Code duplication arises from the DTO objects and entity objects having the same fields which is a conscious design decision we made for separation of concern. So, the code duplication report here isn't a real concern for us.

@krishnan-aot krishnan-aot merged commit 4b8ffba into main Jan 18, 2023
@krishnan-aot krishnan-aot deleted the ORV2-387 branch January 18, 2023 19:02
@praju-aot praju-aot restored the ORV2-387 branch January 18, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants