Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-2406: Fix incorrect company email display on FE company profile form #1414

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

zgong-gov
Copy link
Collaborator

@zgong-gov zgong-gov commented Jun 4, 2024

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

  • Fix incorrect company email display on FE company profile form
  • Rename method for getting email from session to a better name

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Log in as staff user and proceed to company profile page. Take note of the company email displayed, and then click the edit button to show the edit form, and verify that the same company email is displayed in the form (and not the user's email).

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Copy link

sonarcloud bot commented Jun 4, 2024

@zgong-gov zgong-gov merged commit 08eb645 into main Jun 4, 2024
19 checks passed
@zgong-gov zgong-gov deleted the ORV2-2406 branch June 4, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants