Skip to content

Orv2 2312 Secure Scheduler #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 4, 2024
Merged

Orv2 2312 Secure Scheduler #1402

merged 19 commits into from
Jun 4, 2024

Conversation

gchauhan-aot
Copy link
Collaborator

@gchauhan-aot gchauhan-aot commented May 30, 2024

Description

Setting up communication between schedule and vehicle API, for scheduling permit issuance and document generation.
Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested Manually

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@gchauhan-aot gchauhan-aot added the dont merge a branch for anything that shouldn't be merged (yet or ever) label May 30, 2024
Copy link

sonarqubecloud bot commented Jun 4, 2024

Copy link

sonarqubecloud bot commented Jun 4, 2024

Quality Gate Failed Quality Gate failed for 'onroutebc tps_migration'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Jun 4, 2024

Quality Gate Failed Quality Gate failed for 'onroutebc vehicles'

Failed conditions
3.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Collaborator

@praju-aot praju-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may merge once @krishnan-aot signs off

@gchauhan-aot gchauhan-aot merged commit 17ba40a into main Jun 4, 2024
19 of 21 checks passed
@gchauhan-aot gchauhan-aot deleted the ORV2-2312-secure-scheduler branch June 4, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont merge a branch for anything that shouldn't be merged (yet or ever)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants