Fix github environment deploy status issue and replace secret search in pr-open workflow #135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GitHub Environment:
There is an open issue in GitHub where the GitHub Environments status label shows a false "inactive" label when the environment has been successfully deployed and should be active. This bug seems to happen when using a matrix deployment workflow. See here and here
My solution is to run the deployments in order so that the latest deployment status will be shown on the main page of the repository by setting the "max-parallel" option to 1.
GitHub Secrets:
GitHub has released a built-in secret scanning feature which will replace the secret search code in the pr-open workflow.
It has been enabled in our repo using the following steps:
Settings -> Code Security and Analysis -> Secret Scanning -> Enable
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Frontend available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow