Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github environment deploy status issue and replace secret search in pr-open workflow #135

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

devin-aot
Copy link
Contributor

@devin-aot devin-aot commented Jan 12, 2023

Description

GitHub Environment:

There is an open issue in GitHub where the GitHub Environments status label shows a false "inactive" label when the environment has been successfully deployed and should be active. This bug seems to happen when using a matrix deployment workflow. See here and here

My solution is to run the deployments in order so that the latest deployment status will be shown on the main page of the repository by setting the "max-parallel" option to 1.

GitHub Secrets:

GitHub has released a built-in secret scanning feature which will replace the secret search code in the pr-open workflow.
It has been enabled in our repo using the following steps:
Settings -> Code Security and Analysis -> Secret Scanning -> Enable

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@devin-aot devin-aot temporarily deployed to dev January 12, 2023 20:32 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev January 12, 2023 20:32 — with GitHub Actions Inactive
@devin-aot devin-aot temporarily deployed to dev January 12, 2023 20:32 — with GitHub Actions Inactive
@devin-aot devin-aot marked this pull request as ready for review January 12, 2023 20:37
Copy link
Collaborator

@cberg-aot cberg-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Polish!

@cberg-aot cberg-aot merged commit ead5b82 into main Jan 12, 2023
@cberg-aot cberg-aot deleted the fix/github_deploys branch January 12, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants