Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored vite runtime configs and docker compose #120

Merged
merged 4 commits into from
Jan 9, 2023
Merged

Refactored vite runtime configs and docker compose #120

merged 4 commits into from
Jan 9, 2023

Conversation

devin-aot
Copy link
Contributor

@devin-aot devin-aot commented Jan 9, 2023 •
edited by github-actions bot
Loading

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@sonarcloud
Copy link

sonarcloud bot commented Jan 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

cberg-aot
cberg-aot approved these changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@cberg-aot cberg-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after discussion. docker env logic needs todo

@cberg-aot cberg-aot merged commit 56c7255 into main Jan 9, 2023
@cberg-aot cberg-aot deleted the ORV2-405 branch January 9, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cberg-aot cberg-aot cberg-aot approved these changes

@gchauhan-aot gchauhan-aot Awaiting requested review from gchauhan-aot gchauhan-aot is a code owner

@praju-aot praju-aot Awaiting requested review from praju-aot praju-aot is a code owner

@krishnan-aot krishnan-aot Awaiting requested review from krishnan-aot krishnan-aot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devin-aot @cberg-aot