Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated references to env variables on the frontend #117

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Updated references to env variables on the frontend #117

merged 1 commit into from
Jan 9, 2023

Conversation

devin-aot
Copy link
Contributor

@devin-aot devin-aot commented Jan 7, 2023 •
edited
Loading

Description

Since we were able to successfully inject environment variables into the React application at runtime, I have updated the way we get the Deployment Environment (dev, test, uat, prod) and the Vehicle API URL.

I have also updated the reference to the .env file in the frontend so that it points to the .env in the root directory of onroutebc. Now we have the backend, database, and frontend using the same .env file during local development.

Will share env variables in the Teams chat

Fixes # ORV2-405

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Locally using npm start
  • Docker using docker compose up --build -d
  • Openshift using this PR

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@sonarcloud
Copy link

sonarcloud bot commented Jan 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@devin-aot devin-aot marked this pull request as draft January 7, 2023 01:39
@devin-aot devin-aot marked this pull request as ready for review January 9, 2023 17:46
krishnan-aot
krishnan-aot approved these changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@krishnan-aot krishnan-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@devin-aot devin-aot merged commit fc48e9a into main Jan 9, 2023
@devin-aot devin-aot deleted the ORV2-405 branch January 9, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnan-aot krishnan-aot krishnan-aot approved these changes

@cberg-aot cberg-aot Awaiting requested review from cberg-aot cberg-aot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devin-aot @krishnan-aot