Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2 378 - Split back end API into multiple micro services #106

Merged
merged 7 commits into from
Jan 6, 2023
Merged

Conversation

praju-aot
Copy link
Collaborator

@praju-aot praju-aot commented Jan 6, 2023

Description

Made changes to the backend so that vehicles is its own api.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Run docker compose run --build -d, verify container starts successfully
  • Test the swagger Apis at http://:5000/api

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 44 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@devin-aot devin-aot merged commit cb7b00f into main Jan 6, 2023
@devin-aot devin-aot deleted the ORV2-378 branch January 6, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants