Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orv2 319 Bug fixes with ENV file and remove ORM components from DTO #104

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Orv2 319 Bug fixes with ENV file and remove ORM components from DTO #104

merged 2 commits into from
Jan 3, 2023

Conversation

praju-aot
Copy link
Collaborator

@praju-aot praju-aot commented Jan 3, 2023 •
edited by github-actions bot
Loading

Description

Following fixes were done.

  1. Custom env file path has been set in the back.
  2. typeorm components removed from DTO's
  3. Formatting done

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Run docker compose run --build -d, verify container starts successfully
  • Test the swagger Apis at http://:5000/api

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@praju-aot
Env file path and bug fixes
505369e 
1) Set env file path in backend to root of the folder
2) Bug fixes in DTO object
3) Formatting
@praju-aot
Resolve env file in backend
729c3c4
@sonarcloud
Copy link

sonarcloud bot commented Jan 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

gchauhan-aot
gchauhan-aot approved these changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@gchauhan-aot gchauhan-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and Approved

@praju-aot praju-aot merged commit 6a44fe7 into main Jan 3, 2023
@praju-aot praju-aot deleted the ORV2-319 branch January 3, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchauhan-aot gchauhan-aot gchauhan-aot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@praju-aot @gchauhan-aot