Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/572 integrate seedlot creation #579

Merged
merged 16 commits into from
Oct 26, 2023
Merged

Feat/572 integrate seedlot creation #579

merged 16 commits into from
Oct 26, 2023

Conversation

craigyu
Copy link
Collaborator

@craigyu craigyu commented Oct 26, 2023 •
edited
Loading

Description

Fixes #572

This PR integrates the POST: /seedlots endpoint, where users are able to submit a seedlot and create an entry in the database.

Key changes:

  • Form validation and error handling
  • Added a default indicator row on the backend table seedlot_source_list
  • Redirection to the seedlot success page
  • Added react-toastify to handle toast notification, the carbon toast is basically useless since it offers no animation and positioning. So we'll have to settle with this hacky solution. More at: How to open a Toast? carbon-design-system/carbon#7627

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

manual + cypress

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend
Frontend
Oracle-API

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@craigyu craigyu added the full-stack full-stack related task label Oct 26, 2023
@craigyu craigyu self-assigned this Oct 26, 2023
@craigyu craigyu linked an issue Oct 26, 2023 that may be closed by this pull request
[Staged] Integrate Seedlot Creation #572
Closed
RMCampos
RMCampos approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🎈 Only one comment, though.

frontend/cypress/e2e/smoke-test/create-a-class-seedlot.cy.ts Outdated Show resolved Hide resolved
@craigyu craigyu merged commit e983ca4 into staging/seedlots-endpoint-integration Oct 26, 2023
19 of 20 checks passed
@craigyu craigyu deleted the feat/572-integrate-seedlot-creation branch October 26, 2023 20:40
@craigyu craigyu mentioned this pull request Nov 15, 2023
Merged
craigyu added a commit that referenced this pull request Nov 20, 2023
@craigyu @DerekRoberts
Staging/seedlots endpoint integration (#662)
c93446c 
* Feat/572 integrate seedlot creation (#579)

* fix: refactor class a reg screen

* feat: add default ind to seedlot source table

* feat: error handling and submission complete

* feat: implement feedback page

* fix: update cypres test

* fix: remove outdated ci call

* fix: add japadog

* fix: use string array for old components

* fix: wrong type

* fix: adding CI back

* fix: fix import

* fix: react prop error

* fix: use bool

* fix: mock status code

* Feat/573 integrate get all recent seedlots (#593)

* fix: use user_id instead of name in seedlot table

* fix: refactor seedlot table and more

* feat: table refactor complete

* feat: add 404 and simple redirect

* feat: retrieve seedlot by number

* fix: stage changes

* feat: refactor seedlot detail

* feat: refactor seedlot summary

* fix: use useEffect to populate data

* feat: restyle seedlot detail

* fix: refactor forms

* fix: fix test

* fix: import error

* Declare luxon for types

* fix: misc fixes

* fix: separate render functions

* fix: add hyphen

---------

Co-authored-by: Derek Roberts <[email protected]>

* Feat/595 my seedlot page endpoint integration (#616)

* fix: use user_id instead of name in seedlot table

* fix: refactor seedlot table and more

* feat: table refactor complete

* feat: add 404 and simple redirect

* feat: retrieve seedlot by number

* fix: stage changes

* feat: refactor seedlot detail

* feat: refactor seedlot summary

* fix: use useEffect to populate data

* feat: restyle seedlot detail

* fix: refactor forms

* fix: fix test

* fix: import error

* Declare luxon for types

* fix: misc fixes

* fix: separate render functions

* fix: add hyphen

* feat: modularize seedlot table further

* feat: sorting complete

* feat: search complete

* fix: search bug

* feat: include total count in http header, also fixed service test

* feat: front end detects total count from headers

* feat: pass total count prop

* feat: pagination and styles

* fix: styles

* fix: border style

* fix: remove commented out code

---------

Co-authored-by: Derek Roberts <[email protected]>

* feat: making it work with fam changes

* fix: duplicated id bug

* fix: remove signed props

* fix: dup id

* fix: style

* fix: user new user_id format

* fix: java test

---------

Co-authored-by: Derek Roberts <[email protected]>
DerekRoberts added a commit that referenced this pull request May 13, 2024
@craigyu @DerekRoberts
Staging/seedlots endpoint integration (#662)
10380a9 
* Feat/572 integrate seedlot creation (#579)

* fix: refactor class a reg screen

* feat: add default ind to seedlot source table

* feat: error handling and submission complete

* feat: implement feedback page

* fix: update cypres test

* fix: remove outdated ci call

* fix: add japadog

* fix: use string array for old components

* fix: wrong type

* fix: adding CI back

* fix: fix import

* fix: react prop error

* fix: use bool

* fix: mock status code

* Feat/573 integrate get all recent seedlots (#593)

* fix: use user_id instead of name in seedlot table

* fix: refactor seedlot table and more

* feat: table refactor complete

* feat: add 404 and simple redirect

* feat: retrieve seedlot by number

* fix: stage changes

* feat: refactor seedlot detail

* feat: refactor seedlot summary

* fix: use useEffect to populate data

* feat: restyle seedlot detail

* fix: refactor forms

* fix: fix test

* fix: import error

* Declare luxon for types

* fix: misc fixes

* fix: separate render functions

* fix: add hyphen

---------

Co-authored-by: Derek Roberts <[email protected]>

* Feat/595 my seedlot page endpoint integration (#616)

* fix: use user_id instead of name in seedlot table

* fix: refactor seedlot table and more

* feat: table refactor complete

* feat: add 404 and simple redirect

* feat: retrieve seedlot by number

* fix: stage changes

* feat: refactor seedlot detail

* feat: refactor seedlot summary

* fix: use useEffect to populate data

* feat: restyle seedlot detail

* fix: refactor forms

* fix: fix test

* fix: import error

* Declare luxon for types

* fix: misc fixes

* fix: separate render functions

* fix: add hyphen

* feat: modularize seedlot table further

* feat: sorting complete

* feat: search complete

* fix: search bug

* feat: include total count in http header, also fixed service test

* feat: front end detects total count from headers

* feat: pass total count prop

* feat: pagination and styles

* fix: styles

* fix: border style

* fix: remove commented out code

---------

Co-authored-by: Derek Roberts <[email protected]>

* feat: making it work with fam changes

* fix: duplicated id bug

* fix: remove signed props

* fix: dup id

* fix: style

* fix: user new user_id format

* fix: java test

---------

Co-authored-by: Derek Roberts <[email protected]>
DerekRoberts added a commit that referenced this pull request May 14, 2024
@craigyu @DerekRoberts
Staging/seedlots endpoint integration (#662)
a9e4996 
* Feat/572 integrate seedlot creation (#579)

* fix: refactor class a reg screen

* feat: add default ind to seedlot source table

* feat: error handling and submission complete

* feat: implement feedback page

* fix: update cypres test

* fix: remove outdated ci call

* fix: add japadog

* fix: use string array for old components

* fix: wrong type

* fix: adding CI back

* fix: fix import

* fix: react prop error

* fix: use bool

* fix: mock status code

* Feat/573 integrate get all recent seedlots (#593)

* fix: use user_id instead of name in seedlot table

* fix: refactor seedlot table and more

* feat: table refactor complete

* feat: add 404 and simple redirect

* feat: retrieve seedlot by number

* fix: stage changes

* feat: refactor seedlot detail

* feat: refactor seedlot summary

* fix: use useEffect to populate data

* feat: restyle seedlot detail

* fix: refactor forms

* fix: fix test

* fix: import error

* Declare luxon for types

* fix: misc fixes

* fix: separate render functions

* fix: add hyphen

---------

Co-authored-by: Derek Roberts <[email protected]>

* Feat/595 my seedlot page endpoint integration (#616)

* fix: use user_id instead of name in seedlot table

* fix: refactor seedlot table and more

* feat: table refactor complete

* feat: add 404 and simple redirect

* feat: retrieve seedlot by number

* fix: stage changes

* feat: refactor seedlot detail

* feat: refactor seedlot summary

* fix: use useEffect to populate data

* feat: restyle seedlot detail

* fix: refactor forms

* fix: fix test

* fix: import error

* Declare luxon for types

* fix: misc fixes

* fix: separate render functions

* fix: add hyphen

* feat: modularize seedlot table further

* feat: sorting complete

* feat: search complete

* fix: search bug

* feat: include total count in http header, also fixed service test

* feat: front end detects total count from headers

* feat: pass total count prop

* feat: pagination and styles

* fix: styles

* fix: border style

* fix: remove commented out code

---------

Co-authored-by: Derek Roberts <[email protected]>

* feat: making it work with fam changes

* fix: duplicated id bug

* fix: remove signed props

* fix: dup id

* fix: style

* fix: user new user_id format

* fix: java test

---------

Co-authored-by: Derek Roberts <[email protected]>
DerekRoberts added a commit that referenced this pull request May 14, 2024
@craigyu @DerekRoberts
Staging/seedlots endpoint integration (#662)
58e8195 
* Feat/572 integrate seedlot creation (#579)

* fix: refactor class a reg screen

* feat: add default ind to seedlot source table

* feat: error handling and submission complete

* feat: implement feedback page

* fix: update cypres test

* fix: remove outdated ci call

* fix: add japadog

* fix: use string array for old components

* fix: wrong type

* fix: adding CI back

* fix: fix import

* fix: react prop error

* fix: use bool

* fix: mock status code

* Feat/573 integrate get all recent seedlots (#593)

* fix: use user_id instead of name in seedlot table

* fix: refactor seedlot table and more

* feat: table refactor complete

* feat: add 404 and simple redirect

* feat: retrieve seedlot by number

* fix: stage changes

* feat: refactor seedlot detail

* feat: refactor seedlot summary

* fix: use useEffect to populate data

* feat: restyle seedlot detail

* fix: refactor forms

* fix: fix test

* fix: import error

* Declare luxon for types

* fix: misc fixes

* fix: separate render functions

* fix: add hyphen

---------

Co-authored-by: Derek Roberts <[email protected]>

* Feat/595 my seedlot page endpoint integration (#616)

* fix: use user_id instead of name in seedlot table

* fix: refactor seedlot table and more

* feat: table refactor complete

* feat: add 404 and simple redirect

* feat: retrieve seedlot by number

* fix: stage changes

* feat: refactor seedlot detail

* feat: refactor seedlot summary

* fix: use useEffect to populate data

* feat: restyle seedlot detail

* fix: refactor forms

* fix: fix test

* fix: import error

* Declare luxon for types

* fix: misc fixes

* fix: separate render functions

* fix: add hyphen

* feat: modularize seedlot table further

* feat: sorting complete

* feat: search complete

* fix: search bug

* feat: include total count in http header, also fixed service test

* feat: front end detects total count from headers

* feat: pass total count prop

* feat: pagination and styles

* fix: styles

* fix: border style

* fix: remove commented out code

---------

Co-authored-by: Derek Roberts <[email protected]>

* feat: making it work with fam changes

* fix: duplicated id bug

* fix: remove signed props

* fix: dup id

* fix: style

* fix: user new user_id format

* fix: java test

---------

Co-authored-by: Derek Roberts <[email protected]>
DerekRoberts added a commit that referenced this pull request May 14, 2024
@craigyu @DerekRoberts
Staging/seedlots endpoint integration (#662)
89be43f 
* Feat/572 integrate seedlot creation (#579)

* fix: refactor class a reg screen

* feat: add default ind to seedlot source table

* feat: error handling and submission complete

* feat: implement feedback page

* fix: update cypres test

* fix: remove outdated ci call

* fix: add japadog

* fix: use string array for old components

* fix: wrong type

* fix: adding CI back

* fix: fix import

* fix: react prop error

* fix: use bool

* fix: mock status code

* Feat/573 integrate get all recent seedlots (#593)

* fix: use user_id instead of name in seedlot table

* fix: refactor seedlot table and more

* feat: table refactor complete

* feat: add 404 and simple redirect

* feat: retrieve seedlot by number

* fix: stage changes

* feat: refactor seedlot detail

* feat: refactor seedlot summary

* fix: use useEffect to populate data

* feat: restyle seedlot detail

* fix: refactor forms

* fix: fix test

* fix: import error

* Declare luxon for types

* fix: misc fixes

* fix: separate render functions

* fix: add hyphen

---------

Co-authored-by: Derek Roberts <[email protected]>

* Feat/595 my seedlot page endpoint integration (#616)

* fix: use user_id instead of name in seedlot table

* fix: refactor seedlot table and more

* feat: table refactor complete

* feat: add 404 and simple redirect

* feat: retrieve seedlot by number

* fix: stage changes

* feat: refactor seedlot detail

* feat: refactor seedlot summary

* fix: use useEffect to populate data

* feat: restyle seedlot detail

* fix: refactor forms

* fix: fix test

* fix: import error

* Declare luxon for types

* fix: misc fixes

* fix: separate render functions

* fix: add hyphen

* feat: modularize seedlot table further

* feat: sorting complete

* feat: search complete

* fix: search bug

* feat: include total count in http header, also fixed service test

* feat: front end detects total count from headers

* feat: pass total count prop

* feat: pagination and styles

* fix: styles

* fix: border style

* fix: remove commented out code

---------

Co-authored-by: Derek Roberts <[email protected]>

* feat: making it work with fam changes

* fix: duplicated id bug

* fix: remove signed props

* fix: dup id

* fix: style

* fix: user new user_id format

* fix: java test

---------

Co-authored-by: Derek Roberts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMCampos RMCampos RMCampos approved these changes

@mgaseta mgaseta Awaiting requested review from mgaseta

@DerekRoberts DerekRoberts Awaiting requested review from DerekRoberts

@SLDonnelly SLDonnelly Awaiting requested review from SLDonnelly

Assignees

@craigyu craigyu

Labels
full-stack full-stack related task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Staged] Integrate Seedlot Creation
2 participants
@craigyu @RMCampos