-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OHID-161,164, 165 .Feedback form bugs fix #669
Open
AdityaMantripragada
wants to merge
9
commits into
develop
Choose a base branch
from
OHID-161,164-Disable-text-input-in-feedback-form's-screenshot-and-Dialog-Box-Display-Issue-
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
OHID-161,164, 165 .Feedback form bugs fix #669
AdityaMantripragada
wants to merge
9
commits into
develop
from
OHID-161,164-Disable-text-input-in-feedback-form's-screenshot-and-Dialog-Box-Display-Issue-
+114
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
…ck-form's-screenshot-and-Dialog-Box-Display-Issue-
Loading status checks…
…enshot-and-Dialog-Box-Display-Issue-' of https://github.com/bcgov/moh-pidp into OHID-161,164-Disable-text-input-in-feedback-form's-screenshot-and-Dialog-Box-Display-Issue-
Loading status checks…
…ck-form's-screenshot-and-Dialog-Box-Display-Issue-
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Ready For Review
PR is code-complete (or very close) and only needs some review and/or manual testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed below:
OHID-161-In the feedback component, the screenshot and attachment box should not allow text input.
OHID 164-After submitting the password and confirmation password in BC provider page , the user is redirected to the home page where the dialog box is broken.
OHID-165-When users take a screenshot after scrolling down a page, the header appears in the middle of the screen instead of staying fixed at the top.