Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6029] Tools for reviewing amalgamated permit amendments #3396

Merged
merged 45 commits into from
Feb 5, 2025

Conversation

simensma-fresh
Copy link
Collaborator

@simensma-fresh simensma-fresh commented Jan 29, 2025

Objective

MDS-6029

Added some tools to better handle permit amendments in the permit extraction flow.

History Modal
image
image

Added a side by side view to view a diff between the current condition and what it was in the previous amendment following these rules:

  • 100% textual match -> No highlight
  • 80% textual match -> Show the textual diff (highlight additions in green / removals in red)

  • < 80% textual match -> Consider condition as "new" (highlight in full green)
  • 80% textual match but numbering has changed -> Highlight in blue (moved)

This is calculated on demand when opening the history to capture any changes you've made.

Auto Approval
Modified permit condition create to auto-approve any top level conditions where the condition itself and any of the children all 100% match a section in the previous amendment when it comes to text and structure

Report Copying
If a textual match (> 80%) in the previous amendment, we copy the report requirement from the matching condition

Flow
An update was made so the Permit Conditions tab now by default shows the latest amendment that was reviewed. This is what a lot of the small changes regarding currentAmendment, and latestAmendment are about.

latestAmendment: The latest amendment of the permit (regardless of the approval status)
currentAmendment: The amendment you're currently viewing conditions for. This will always match the new permitAmendmentGuid in the url params.

image
image

@simensma-fresh simensma-fresh force-pushed the MDS-6029_replacement-permit-amendment branch from dd17492 to 73b1739 Compare January 30, 2025 21:32
@simensma-fresh simensma-fresh changed the title [MDS-6029] DRAFT Amalgamated permit amendment views [MDS-6029] Tools for reviewing amalgamated permit amendments Jan 30, 2025
@simensma-fresh simensma-fresh marked this pull request as ready for review January 30, 2025 23:38
@simensma-fresh simensma-fresh requested review from taraepp, matbusby-fw, sggerard and asinn134 and removed request for matbusby-fw January 30, 2025 23:55
matbusby-fw
matbusby-fw previously approved these changes Feb 3, 2025
Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome. Liking the use of the new AppSelector and the few sneaky improvements in here!

matbusby-fw
matbusby-fw previously approved these changes Feb 5, 2025
@simensma-fresh simensma-fresh force-pushed the MDS-6029_replacement-permit-amendment branch from 3608278 to da2f7c6 Compare February 5, 2025 18:44
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
42.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'

Failed conditions
73.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link

sonarqubecloud bot commented Feb 5, 2025

@simensma-fresh simensma-fresh merged commit 6a0490e into develop Feb 5, 2025
18 of 20 checks passed
@simensma-fresh simensma-fresh deleted the MDS-6029_replacement-permit-amendment branch February 5, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants