[MDS-5049]fix tsf mapping null error #2839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asinn134
commented
Dec 8, 2023
| @@ -173,6 +173,7 @@ export const NOTICE_OF_DEPARTURE_STATUS_VALUES = { | |||
| determined_non_substantial: "determined_non_substantial", | |||
| determined_substantial: "determined_substantial", | |||
| withdrawn: "withdrawn", | |||
| self_authorized: "self_authorized", | |||
There was a problem hiding this comment.
Noticed this was missing and causing an error in mds\services\core-web\src\components\modalContent\NoticeOfDepartureModal.tsx line 203. I just added this here not sure if anyone has anymore context or if this is the correct string value to set for this?
asinn134
requested review from
simensma-fresh,
henryoforeh-dev,
matbusby-fw,
taraepp and
isuru-aot
henryoforeh-dev
approved these changes
Dec 8, 2023
taraepp
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
MDS-5049
-There was an null error occurring when TSF page was opened in the test environment.
-The error was due to my recent merge not having all the up to date changes in the develop branch, so for example in my branch I had something like this renderActionsColumn(newTSFActions) when it should be renderActionsColumn({ actions: newTSFActions })
-Also did some small refactor in the TSF section